Re: [PATCH] i2c: add sanity check to i2c_put_adapter

From: Wolfram Sang
Date: Mon Aug 05 2013 - 06:47:20 EST

On Mon, Aug 05, 2013 at 11:31:42AM +0200, Sebastian Hesselbarth wrote:
> On 08/05/13 11:00, Wolfram Sang wrote:
> >On Thu, Aug 01, 2013 at 02:10:46PM +0200, Sebastian Hesselbarth wrote:
> >>i2c_put_adapter dereferences i2c_adapter pointer passed without check
> >>for NULL. This adds a check for non-NULL pointer to allow i2c_put_adapter
> >>called with NULL and behave the same way i2c_release_client does already.
> >
> >What about using WARN for the NULL case to point out the ref-counting
> >imbalance?
> Wolfram,
> I was just adding this to (a) make it consistent with i2c_release_client
> and (b) it allows to simplify drivers where you need to release the
> adapter during probe failures. But that patch is so small, feel free to
> squash in anything you like.

I am not forcing you to do this, I am calling for opinions here.

Attachment: signature.asc
Description: Digital signature