Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and whitespace issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pltool

From: Henk de Groot
Date: Sun Aug 04 2013 - 11:49:50 EST


Hello Evan,

When reformatting the array containing the firmware data it may be easier to use 8 bytes per row. It is currently it is 16 bytes per row (overrunning the 80 characters/line) and this just means cutting each row exactly in half. In your first proposal it was completely reformatted to an odd 11 bytes per row which makes comparison with the original during review much harder and it is also easier to make mistakes.

Kind regards,

Henk.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/