Re: [PATCH] acpi: video: improve quirk check

[Felipe Contreras]

On Sat, Aug 3, 2013 at 5:38 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote:
>> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>> > On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote:
>> >> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>> >> > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote:
>> >>
>> >> >> Yes, the patch is correct, but I still prefer my own version :-)
>> >> >> https://github.com/aaronlu/linux/commit/0a3d2c5b59caf80ae5bb1ca1fda0f7bf448b38c9
>> >> >>
>> >> >> In case you want to take mine and mine needs refresh, please let me know
>> >> >> and I can do the re-base, thanks.
>> >> >
>> >> > Well, I prefer simpler, unless there's a good reason to use more complicated.
>> >>
>> >> Note that these are not exclusionary; his patch can be applied on top
>> >> of mine. I don't think his patch is needed though.
>> >
>> > OK
>> >
>> > Do we still need to revert commit efaa14c if this patch is applied?
>>
>> I guess not. At least in this machine changing the backlight works
>> correctly, whereas in v3.11-rc3 it was all weird, and v3.7-v3.10
>> didn't work at all. I cannot see how it would affect negatively other
>> machines.
>>
>> That being said, the blacklisting is still needed, because 1. the
>> level is not preserved between boots, and 2. level 0 turns off the
>> screen, which I personally consider a regression.
>>
>> At least it boots to level 100 instead of 0.
>
> OK
>
> I'll push this patch to Linus for -rc5 then without the revert of commit
> commit efaa14c.  That's all I'm going to do for 3.11 in the ACPI video
> area at this point.

That seems fair.

> As far as the blacklisting is concerned, I still have the blacklist of
> your Asus machine queued up for 3.12.  Since you're claiming that it
> doesn't have any side effects on that machine, I think I can apply it.
>
> However, for other machines to be added to that blacklist I need to see
> requests from their users with confirmation that there are no visible side
> effects there.

Good, that's the purpose of bug 60682.

https://bugzilla.kernel.org/show_bug.cgi?id=60682

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/