Re: [PATCH 3/3] exec: proc_exec_connector() should be called only once

From: Kees Cook
Date: Sat Aug 03 2013 - 15:10:17 EST


On Thu, Aug 1, 2013 at 12:05 PM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> A separate one-liner with the minor fix.
>
> PROC_EVENT_EXEC reports the "exec" event, but this message
> is sent at least twice if search_binary_handler() is called
> by ->load_binary() recursively, say, load_script().
>
> Move it to exec_binprm(), this is "depth == 0" code too.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Yeah, looks right. I almost mentioned this while reading the other
cleanup patch, but then you fixed it too. :)

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

Thanks,

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/