Re: [PATCH 2/3] exec: kill "int depth" in search_binary_handler()

From: Kees Cook
Date: Sat Aug 03 2013 - 14:28:21 EST

On Thu, Aug 1, 2013 at 12:05 PM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> Nobody except search_binary_handler() should touch ->recursion_depth,
> "int depth" buys nothing but complicates the code, kill it.

I'd like to see a comment added to binfmts.h's recursion_depth field
that reminds people that recursion_depth is for
search_binary_handler()'s use only, and a binfmt loader shouldn't
touch it. Besides that, yeah, sensible clean up.


Kees Cook
Chrome OS Security
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at