Re: [PATCH v3 2/4] ASoc: kirkwood: merge kirkwood-i2c andkirkwood-dma

From: Russell King - ARM Linux
Date: Sat Aug 03 2013 - 07:46:40 EST


On Sat, Aug 03, 2013 at 12:43:21PM +0100, Russell King - ARM Linux wrote:
> On Wed, Jul 31, 2013 at 08:18:06AM +0200, Jean-Francois Moine wrote:
> > To avoid the declaration of a 'kirkwood-pcm-audio' device in the DT,
> > this patch merges the kirkwood-i2c and kirkwood-dma drivers into one
> > module associated with 'kirkwood-i2s'.
>
> This is broken unless you use my patch. You can't just stick the
> two drivers together because they both make use of the platform
> device's driver data field for two incompatible uses. I've already
> explained that, and I've even sent you a patch to fix that, but you
> seem to ignore anything that you didn't write.
>
> So... I'm going to work on this issue this weekend and merge the two
> drivers myself, and send Mark my own patches to do this.

Sorry, I take that back, your cover email does say that this depends on
my patch. I'll give your patches a go this weekend instead then. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/