regulator: s2mps11: Question about the code updating ramp_delaysetting

From: Axel Lin
Date: Sat Aug 03 2013 - 05:13:18 EST

Hi Yadwinder,
The code updating ramp_delay setting looks wrong to me.

Current code:
return regmap_update_bits(rdev->regmap, ramp_reg,
ramp_val << ramp_shift, 1 << ramp_shift);
I'd expect something like below:
return regmap_update_bits(rdev->regmap, ramp_reg,
ramp_mask << ramp_shift,
ramp_val << ramp_shift);
I don't have the datasheet so I don't know the correct ramp_mask setting
here. Can you check if this needs fix?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at