Re: [PATCH] mm, numa: Do not group on RO pages

[Peter Zijlstra]

> +	/*
> +	 * Avoid grouping on DSO/COW pages in specific and RO pages
> +	 * in general, RO pages shouldn't hurt as much anyway since
> +	 * they can be in shared cache state.
> +	 */

OK, so that comment is crap. Its that you cannot work into RO pages and
this RO pages don't establish a collaboration.

> +	if (page_mapcount(page) != 1 && !pmd_write(pmd))
> +		flags |= TNF_NO_GROUP;

Rik also noted that mapcount == 1 will trivially not form groups. This
should indeed be so but I didn't test it without that clause.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/