Re: [PATCH 08/23] cgroup: pass around cgroup_subsys_state instead ofcgroup in subsystem methods

From: Tejun Heo
Date: Fri Aug 02 2013 - 15:41:54 EST


On Fri, Aug 02, 2013 at 12:02:05PM +0800, Li Zefan wrote:
> > @@ -4199,12 +4208,13 @@ static void init_cgroup_css(struct cgroup_subsys_state *css,
> > /* invoke ->css_online() on a new CSS and mark it online if successful */
> > static int online_css(struct cgroup_subsys *ss, struct cgroup *cgrp)
> > {
> > + struct cgroup_subsys_state *css = cgrp->subsys[ss->subsys_id];
> > int ret = 0;
> >
> > lockdep_assert_held(&cgroup_mutex);
> >
> > if (ss->css_online)
> > - ret = ss->css_online(cgrp);
> > + ret = ss->css_online(css);
> > if (!ret)
> > cgrp->subsys[ss->subsys_id]->flags |= CSS_ONLINE;
>
> Then this can be changed to css->flags |= CSS_ONLINE.

Aye aye.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/