Re: [PATCH 2/3] acpi: video: trivial style cleanups

[Felipe Contreras]

On Fri, Aug 2, 2013 at 9:09 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Thursday, August 01, 2013 11:18:34 PM Felipe Contreras wrote:
>> On Thu, Aug 1, 2013 at 8:55 PM, Aaron Lu <aaron.lwe@xxxxxxxxx> wrote:
>> > On 08/02/2013 07:44 AM, Felipe Contreras wrote:
>> >> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
>> >
>> > Change log please.
>>
>> You mean a commit message?
>
> No.  He meant the part that goes between the subject and the signoff.
> This is called a change log (or changelog).

Not in Git lingo.

% man git commit

"Though not required, itâs a good idea to begin the commit message
with a single short (less than 50 character) line summarizing the
change, followed by a blank line and then a more thorough
description."

>> That's what it's called in Git lingo, and
>> it's right there:
>>
>> acpi: video: trivial style cleanups
>
> And that's not sufficient, because it doesn't explain *what* cleanups are
> being made.

Yes it does; *style* cleanups (coding-style).

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/