Re: [PATCH 0/3] exec: minor cleanups + minor fix

[Zach Levis]

On 08/02/2013 07:09 AM, Oleg Nesterov wrote:
> On 08/01, Oleg Nesterov wrote:
> > Andrew,
> >
> > By discussion with Zach, please drop
> >
> > 	fs-binfmts-add-a-name-field-to-the-binfmt-struct.patch
> > 	fs-binfmts-better-handling-of-binfmt-loops.patch
> > 	fs-binfmts-whitespace-fixes-with-scripts-cleanfile.patch
> >
> > Zach is working on v2.
> >
> > Meanwhile, can't we cleanup search_binary_handler() a bit? It
> > doesn't look nice imho. And we can certainly cleanup it more
> > (perhaps I'll try tomorrow). The error handling, request_module()
> > logic and even "for (try=0; try<2; try++)" looks horrible imho.
>
> Seriously, I think this should be cleanuped too.
>
> Zach, I am sorry if you already rebased your changes, I'll send
> a couple more patches today.
Don't worry -- I've been holding off on sending v2 for your changes 
today. It's not much git wrangling to apply your additional patches anyway.

> Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/