Re: [PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

From: Thierry Reding
Date: Fri Aug 02 2013 - 08:31:07 EST


On Thu, Aug 01, 2013 at 06:39:10PM +0200, Stephen Warren wrote:
> On 08/01/2013 09:00 AM, Tuomas Tynkkynen wrote:
> > Add device tree entries for the 3 USB controllers and PHYs and
> > enable the third controller on Cardhu and Beaver boards.
> >
> > Fix VBUS regulator entries on Beaver. The GPIO pins were wrong.
> > Also, internal pullups need to be enabled on those pins.
> >
> > Signed-off-by: Tuomas Tynkkynen <ttynkkynen@xxxxxxxxxx>
> > ---
> > v2: Use internal pullups on the VBUS regulator GPIOs.
>
> Thanks, this version looks good.
>
> Thierry, can you please validate that the gpv group pull strength change
> doesn't have any negative affect on your PCIe patches. Thanks.

PCIe on Beaver seems to behave the same way whether that patch is
applied or not, so:

Tested-by: Thierry Reding <treding@xxxxxxxxxx>

I wonder if perhaps a similar change can be made to Cardhu to see if
that helps with the PCIe link disappearing. I'll see if I can find out
what the implications are and what the correct values would be for
Cardhu.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature