Re: [PATCH 3/3] regulators: max8660: add DT bindings

[Mark Brown]

On Fri, Aug 02, 2013 at 10:19:17AM +0200, Daniel Mack wrote:

> +Required properties:
> +- compatible: must be equal to "maxim,max8660"

This...

> +#ifdef CONFIG_OF
> +static const struct of_device_id max8660_dt_ids[] = {
> +	{ .compatible = "maxim,max8660", .data = (void *) MAX8660 },
> +	{ .compatible = "maxim,max8661", .data = (void *) MAX8661 },

...and this don't match up.

>  struct max8660_subdev_data {
>  	int				id;
> -	char				*name;
> +	const char			*name;
>  	struct regulator_init_data	*platform_data;
> +	struct device_node		*of_node;
>  };

Can't you just pass the of_node around while you need it?  Not that it
makes a big difference.

Otherwise looks good.

Attachment: signature.asc
Description: Digital signature