Re: [PATCH] rtc: rtc-stmp3xxx: provide timeout for potentiallyendless loop polling a HW bit

From: Wolfram Sang
Date: Fri Aug 02 2013 - 04:06:45 EST


On Wed, Jul 31, 2013 at 04:29:01PM +0200, Lothar Waßmann wrote:
> It's always a bad idea to poll on HW bits without a timeout.
>
> The i.MX28 RTC can be easily brought into a state in which the RTC is
> not running (until after a power-on-reset) and thus the status bits
> which are polled in the driver won't ever change.
>
> This patch prevents the kernel from getting stuck in this case.
>
> Signed-off-by: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx>

Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: Digital signature