Re: [PATCH v2] usb: gadget: at91_udc: add usb_clk for transition tocommon clk framework

From: Felipe Balbi
Date: Fri Aug 02 2013 - 03:47:43 EST


Hi,

On Thu, Aug 01, 2013 at 07:07:50PM +0200, Boris BREZILLON wrote:
> @@ -1851,6 +1860,12 @@ fail3:
> fail2:
> free_irq(udc->udp_irq, udc);
> fail1:
> + if (IS_ENABLED(CONFIG_COMMON_CLK) && !IS_ERR(udc->uclk))
> + clk_put(udc->uclk);
> + if (!IS_ERR(udc->fclk))
> + clk_put(udc->fclk);
> + if (!IS_ERR(udc->iclk))
> + clk_put(udc->iclk);

adding missing clk_put() for iclk and fclk should be part of a separate
patch. Please split this part.

--
balbi

Attachment: signature.asc
Description: Digital signature