Re: [RESEND PATCH 1/2] ARM: msm: Add support for MSM8974

From: David Brown
Date: Fri Aug 02 2013 - 00:21:13 EST

On Thu, Aug 01, 2013 at 08:36:38PM -0700, Rohit Vaswani wrote:
On 8/1/2013 7:29 PM, Stephen Warren wrote:
On 08/01/2013 07:23 PM, Rohit Vaswani wrote:
This patch adds basic board support for MSM8974 which
belongs to the Snapdragon 800 family.
For now, just support a basic machine with device tree.
arch/arm/boot/dts/msm8974.dts | 26 ++++++++++++++++++++++++++
That's odd. If this is support for an SoC, why not a *.dtsi file rather
than *.dts?

I am not sure why I would need a dtsi if I am just adding the 1 file for
the SoC support ?

The .dts file should be for a specific board, not a general SoC. Note
the names of the other board .dts files for MSM. We'll probably want
a msm8974.dtsi at some point, though.


sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at