Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and whitespace issue in ap_h2.c Fixed various coding style warnings found by tool

From: Greg KH
Date: Thu Aug 01 2013 - 17:49:11 EST

On Wed, Jul 31, 2013 at 01:44:25PM -0700, Evan Ng wrote:
> From: esn89 <>

I need a real name here, odds are "esn89" isn't yours :)

Also, look at the subject you created, it's not correct, you need to add
a newline after a short description, followed by the longer description,
for git to pick this up properly.

> Signed-off-by: Evan Ng <>
> ---
> drivers/staging/wlags49_h2/ap_h2.c | 7884 +++++++++++++++++++++---------------
> 1 file changed, 4668 insertions(+), 3216 deletions(-)

That's almos impossible to review, can you do "one thing at a time" so
that we can review it? Break it up into lots of different pieces and
send a series of patches.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at