[PATCH] cpufreq: Avoid double kobject_put() for the same kobject in error code path

From: Rafael J. Wysocki
Date: Thu Aug 01 2013 - 17:20:57 EST

From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

The only case triggering a jump to the err_out_unregister label in
__cpufreq_add_dev() is when cpufreq_add_dev_interface() fails.
However, if cpufreq_add_dev_interface() fails, it calls kobject_put()
for the policy kobject in its error code path and since that causes
the kobject's refcount to become 0, the additional kobject_put() for
the same kobject under err_out_unregister and the
wait_for_completion() following it are pointless, so drop them.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
drivers/cpufreq/cpufreq.c | 3 ---
1 file changed, 3 deletions(-)

Index: linux-pm/drivers/cpufreq/cpufreq.c
--- linux-pm.orig/drivers/cpufreq/cpufreq.c
+++ linux-pm/drivers/cpufreq/cpufreq.c
@@ -1109,9 +1109,6 @@ err_out_unregister:
write_unlock_irqrestore(&cpufreq_driver_lock, flags);

- kobject_put(&policy->kobj);
- wait_for_completion(&policy->kobj_unregister);
per_cpu(cpufreq_policy_cpu, cpu) = -1;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/