Re: [PATCH] macvlan: validate flags

From: Sergei Shtylyov
Date: Thu Aug 01 2013 - 10:36:06 EST


On 01-08-2013 14:48, Michael S. Tsirkin wrote:

commit df8ef8f3aaa6692970a436204c4429210addb23a

Please also specify that commit's summary line in parens.
This is the only way to uniquely identify the commit, and it's the requirement that came originally from Linus AFAIK.

added a flags field to macvlan, which can be
controlled from userspace.
The idea is to make the interface future-proof
so we can add flags and not new fields.

However, flags value isn't validated, as a result,
userspace can't detect which flags are supported.

Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
CC: Roopa Prabhu <roprabhu@xxxxxxxxx>
Cc: John Fastabend <john.r.fastabend@xxxxxxxxx>
Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

WBR, Sergei

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at