Re: [PATCH] checkpatch: Warn when using extern with function prototypes in .h files

From: David Howells
Date: Thu Aug 01 2013 - 08:21:19 EST

Joe Perches <joe@xxxxxxxxxxx> wrote:

> Using the extern keyword on function prototypes is superfluous
> visual noise so suggest removing it.
> Using extern can cause unnecessary line wrapping at 80 columns
> and unnecessarily long multi-line function prototypes.
> Suggested-by: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>


The "extern" makes it much easier to pick out at a glance.

Please standardise on there _being_ externs if you must do this.

It's gratuitous change anyway and not worth the churn.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at