Re: [PATCH] crypto: remove double execution of the same test suite

From: Herbert Xu
Date: Thu Aug 01 2013 - 07:37:58 EST


On Thu, Aug 01, 2013 at 08:11:25AM +0000, Stoica Cristian-B18196 wrote:
> > Which algorithm (apart from crc* which I know and will fix) uses the
> > same driver name as its algorithm name? Doing this will cause issues
> > when an alternative implementation for that algorithm gets added.
>
> Fixing names resolves double calls only for the thread cryptomgr_test->alg_test where the call is:
> err = alg_test(param->driver, param->alg, type, CRYPTO_ALG_TESTED);
>
> It doesn't fix the thread tcrypt_test->alg_test where the call is:
> ret = alg_test(alg, alg, 0, 0);

Good point. I'll apply your patch.

Thanks!
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/