Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support

From: Felipe Ferreri Tonello
Date: Wed Jul 31 2013 - 23:49:34 EST


Hi Takashi,

On 07/29/2013 05:05 AM, Takashi Iwai wrote:
At Sat, 27 Jul 2013 13:25:24 +0100,
Mark Brown wrote:

On Fri, Jul 26, 2013 at 04:13:40PM -0700, Felipe Tonello wrote:
On Fri, Jul 26, 2013 at 3:48 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:

What I'd expect to happen here is that for multi function jacks we
create a control per function if the controls are valid.

Ok, so the idea is just to change the control to type integer instead
of boolean, right?
Because as you say, the user will be able to check the type of jack
based on the status value, right?

It might be more idiomatic and more compatible with userspace to create
multiple controls for the jack, there was some discussion of this in the
past I think but I can't remember the result.

I also forget the end result :)

Another option would be to make an enum control, but multiple boolean
controls are easier in the end. The headset controls of HD-audio are
represented in that way, too (because HD-audio specification can't
tell better).

Yes. Thanks for the comment.

Felipe Tonello
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/