Re: [PATCH] sched, numa: Use {cpu, pid} to create task groups forshared faults

[Peter Zijlstra]

On Wed, Jul 31, 2013 at 11:45:09AM -0400, Don Morris wrote:
> > +
> > +static void task_numa_free(struct task_struct *p)
> > +{
> > +	kfree(p->numa_faults);
> > +	if (p->numa_group) {
> > +		struct numa_group *grp = p->numa_group;
> 
> See below.
> 
> > +		int i;
> > +
> > +		for (i = 0; i < 2*nr_node_ids; i++)
> > +			atomic_long_sub(p->numa_faults[i], &grp->faults[i]);
> > +
> > +		spin_lock(&p->numa_lock);
> > +		spin_lock(&group->lock);
> > +		list_del(&p->numa_entry);
> > +		spin_unlock(&group->lock);
> > +		rcu_assign_pointer(p->numa_group, NULL);
> > +		put_numa_group(grp);
> 
> So is the local variable group or grp here? Got to be one or the
> other to compile...

Feh, compiling is soooo overrated! :-)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/