Re: [PATCH 2/2] chipidea: Use devm_request_irq()

From: Mark Brown
Date: Wed Jul 31 2013 - 09:58:25 EST


On Wed, Jul 31, 2013 at 09:42:15AM -0400, Tejun Heo wrote:
> On Wed, Jul 31, 2013 at 02:27:08PM +0100, Mark Brown wrote:

> > It's really only interrupts that affect most devices - if there's DMA or
> > anything going on after the remove() then as you said earlier the driver
> > is probably doing something wrong.

> Hmmm... it depends on the specific driver is converted but if the
> deactivation sequence - shutting down of command engine - is also
> handled by devm as in libata and if you have non-devres resource free
> in the exit path, you have the same problem. Again, in general,

That's the only API I've ever heard of doing that. Everything else is
just using it to do deallocation.

Attachment: signature.asc
Description: Digital signature