Re: [PATCH 2/2] chipidea: Use devm_request_irq()
From: Mark Brown
Date: Wed Jul 31 2013 - 09:27:29 EST
On Wed, Jul 31, 2013 at 07:55:27AM -0400, Tejun Heo wrote:
> If you have DMA / IRQ / command engine deactivations in devm path
> which often is the case with full conversions, freeing any resources
> including DMA areas and host private data in the wrong order is a
> horrible idea. It's worse as it won't really be noticeable in most
> cases.
It's really only interrupts that affect most devices - if there's DMA or
anything going on after the remove() then as you said earlier the driver
is probably doing something wrong.
Attachment:
signature.asc
Description: Digital signature