Re: [PATCH] relay: fix timer madness

[zhangwei(Jovi)]

On 2013/7/31 18:01, zhangwei(Jovi) wrote:
> From: Ingo Molnar <mingo@xxxxxxx>
> 
> When I'm using ktap script to tracing all event tracepoints by relay
> transport, without this patch, the system will hang in few seconds.
> 
> I found the original patch discussion in 2007.
> http://marc.info/?l=linux-kernel&m=118544794717162&w=2
> (In that mail thread, the patch didn't fix that problem, but it fix
> the problem I encountered now)
> 
> Changed from origina patch:
>  - mod timer interval changed from jiffies+1 to HZ/10, as Ingo suggested.
>  - mod timer interval changed from HZ/10 to jiffies + HZ/10, suggested
>    by Dan Carpenter, since mod_timer() takes an offset for interval.
> 
> Original patch changelog from Ingo in 2007:
> 
>   Remove timer calls (!!!) from deep within the tracing infrastructure.
>   This was totally bogus code that can cause lockups and worse.
>   Poll the buffer every 2 jiffies for now.
> 
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> Signed-off-by: "zhangwei(Jovi)" <jovi.zhangwei@xxxxxxxxxx>
> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> ---
Hi Andrew,

How about this patch? this version folded the suggestion from Ingo and Dan.

jovi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/