Re: [PATCH] x86/mce: Pay no attention to 'F' bit in MCACOD when parsing'UC' errors.

From: Naveen N. Rao
Date: Wed Jul 31 2013 - 06:06:50 EST


On 07/25/2013 11:31 PM, Luck, Tony wrote:
MCESEV(
+ PANIC, "Action required but kernel thread is not continuable",
+ SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR, MCI_UC_SAR|MCI_ADDR),
+ MCGMASK(MCG_STATUS_RIPV|MCG_STATUS_EIPV, MCG_STATUS_RIPV|MCG_STATUS_EIPV),
+ KERNEL
+ ),
+ MCESEV(
AR, "Action required: data load error in a user process",
SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR|MCACOD, MCI_UC_SAR|MCI_ADDR|MCACOD_DATA),
USER

This just gives us a better panic message. Right? Without this we'd keep walking the
severity table until we hit the "Action required: unknown MCACOD" entry which will
match and force a panic anyway.

Yes, that's correct. But I felt it would be good to have this entry to make it explicit.


So I might look for better wording. As far as the h/w is concerned the thread is continuable.
Linux is just not smart enough (yet) to take the required recovery action.

Ok, how about: "Action required but unable to recover kernel thread"


Thanks,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/