Re: [PATCH 08/18] sched: Reschedule task on preferred NUMA node onceselected

From: Mel Gorman
Date: Wed Jul 31 2013 - 05:07:42 EST


On Wed, Jul 17, 2013 at 09:31:05AM +0800, Hillf Danton wrote:
> On Mon, Jul 15, 2013 at 11:20 PM, Mel Gorman <mgorman@xxxxxxx> wrote:
> > +static int
> > +find_idlest_cpu_node(int this_cpu, int nid)
> > +{
> > + unsigned long load, min_load = ULONG_MAX;
> > + int i, idlest_cpu = this_cpu;
> > +
> > + BUG_ON(cpu_to_node(this_cpu) == nid);
> > +
> > + rcu_read_lock();
> > + for_each_cpu(i, cpumask_of_node(nid)) {
>
> Check allowed CPUs first if task is given?
>

If the task is not allowed to run on the CPUs for that node then how
were the NUMA hinting faults recorded?

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/