Re: [PATCH v4 07/17] clocksource: bcm2835: Switch to sched_clock_register()

From: Daniel Lezcano
Date: Tue Jul 30 2013 - 06:05:14 EST


On 07/19/2013 01:21 AM, Stephen Boyd wrote:
> The 32 bit sched_clock interface now supports 64 bits. Upgrade to
> the 64 bit function to allow us to remove the 32 bit registration
> interface.
>
> Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> ---

Hi Stephen,

you sent a series with tick and clocksource changes.

John is recipient of part of them. I replaced him to maintain the
clocksource drivers.

Is the series you sent for clocksource drivers supposed to be taken by
me or by Russell ?

In the future if there are no dependencies, it would be preferable to
group the clocksource drivers changes into a series and send them to me.

Thanks
-- Daniel

> drivers/clocksource/bcm2835_timer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/bcm2835_timer.c b/drivers/clocksource/bcm2835_timer.c
> index 07ea7ce..26ed331 100644
> --- a/drivers/clocksource/bcm2835_timer.c
> +++ b/drivers/clocksource/bcm2835_timer.c
> @@ -49,7 +49,7 @@ struct bcm2835_timer {
>
> static void __iomem *system_clock __read_mostly;
>
> -static u32 notrace bcm2835_sched_read(void)
> +static u64 notrace bcm2835_sched_read(void)
> {
> return readl_relaxed(system_clock);
> }
> @@ -110,7 +110,7 @@ static void __init bcm2835_timer_init(struct device_node *node)
> panic("Can't read clock-frequency");
>
> system_clock = base + REG_COUNTER_LO;
> - setup_sched_clock(bcm2835_sched_read, 32, freq);
> + sched_clock_register(bcm2835_sched_read, 32, freq);
>
> clocksource_mmio_init(base + REG_COUNTER_LO, node->name,
> freq, 300, 32, clocksource_mmio_readl_up);
>


--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/