Re: [PATCH] usb: phy-samsung-usb: Simplify PMU register handling

[Julius Werner]

>> -       if (sphy->phy_type == USB_PHY_TYPE_DEVICE) {
>> -               reg = sphy->pmuregs + sphy->drv_data->devphy_reg_offset;
>> -               en_mask = sphy->drv_data->devphy_en_mask;
>> -       } else if (sphy->phy_type == USB_PHY_TYPE_HOST) {
>> -               reg = sphy->pmuregs + sphy->drv_data->hostphy_reg_offset;
>> -               en_mask = sphy->drv_data->hostphy_en_mask;
>> -       }
>
>
> How is en_mask supposed to get initialized, now when this code is removed ?
> It's always 0 now, isn't it ?
>

Whoops... oh, I'm really sorry about that. I ported the patch from a
branch with slightly different code there and overlooked this. Thanks
for catching it, will send v2 in a minute.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/