Re: [ 71/79] ext4: fix error handling in ext4_ext_truncate()

[Theodore Ts'o]

On Sat, Jul 27, 2013 at 10:33:31PM +0100, Ben Hutchings wrote:
> > --- a/fs/ext4/extents.c
> > +++ b/fs/ext4/extents.c
> > @@ -4386,9 +4386,20 @@ void ext4_ext_truncate(handle_t *handle,
> >  
> >  	last_block = (inode->i_size + sb->s_blocksize - 1)
> >  			>> EXT4_BLOCK_SIZE_BITS(sb);
> > +retry:
> >  	err = ext4_es_remove_extent(inode, last_block,
> >  				    EXT_MAX_BLOCKS - last_block);
> > +	if (err == ENOMEM) {
> 
> Positive ENOMEM?!  It looks like this value is bubbled up from
> __es_insert_extent() which returns the usual negative error codes.

Nice catch.  Yup, that's a problem.  I'll fix this upstream and mark
it cc:stable.

Until this goes upstream stable kernel maintainers can either: (a) fix
up this patch by making the line read "err == -ENOMEM", (b) hold back
this patch until the companion patch to fix this goes upstream, or (c)
apply this now, since it's otherwise harmless and it does add error
checking to the ext4_ext_remove_space() call.

> 
> Ben.
> 
> > +		cond_resched();
> > +		congestion_wait(BLK_RW_ASYNC, HZ/50);
> > +		goto retry;
> > +	}
> > +	if (err) {
> > +		ext4_std_error(inode->i_sb, err);
> > +		return;
> > +	}
> >  	err = ext4_ext_remove_space(inode, last_block, EXT_MAX_BLOCKS - 1);
> > +	ext4_std_error(inode->i_sb, err);
> >  }
> >  
> >  static void ext4_falloc_update_inode(struct inode *inode,
> > 
> 
> -- 
> Ben Hutchings
> Once a job is fouled up, anything done to improve it makes it worse.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/