Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

From: Laxman Dewangan
Date: Sat Jul 27 2013 - 06:12:09 EST


On Friday 26 July 2013 10:11 PM, Mark Brown wrote:
* PGP Signed by an unknown key

On Fri, Jul 26, 2013 at 03:45:54PM +0530, Laxman Dewangan wrote:

+pins: gpio0_id, gpio1_vbus_det_led1_pwm1, gpio2_regen_led2_pwm2, gpio3_chrg_det,
+ gpio4_sysen1, gpio5_clk32kgaudio_usb_psel, gpio6_sysen2,
+ gpio7_msecure_pwrhold, gpio8_sim1rsti, gpio9_low_vbat,
+ gpio10_wireless_chrg1, gpio11_rcm, gpio12_sim2rsto, gpio13, gpio14,
+ gpio15_sim2rsti, vac, powergood_usb_psel, nreswarm, pwrdown,
+ gpadc_start, reset_in, nsleep, enable1, enable2, int.
Would it not be easier to just name the GPIOs gpioN rather than using
the full names with the possible functions?


I took the name approach as what we have on Tegra.
But I think I can put the name of the pins same as what we have in datasheet. So pin name will be exact same as what we have in datasheet. That will be easy to interpret.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/