Re: [PATCH 4/4] ALSA: oxygen: Updating jack implementation accordingnew ALSA Jacks

[Felipe Tonello]

Hi Mark,

On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Fri, Jul 26, 2013 at 11:25:33AM -0700, Felipe F. Tonello wrote:
>> From: "Felipe F. Tonello" <eu@xxxxxxxxxxxxxxxxx>
>>
>> ALSA standard jacks already are implemented using ALSA KControl.
>> So there is no need implement that itself or to use snd_jack
>> for input events only.
>
> Similar changlog comment as on the ASoC patch and...

Ok.

>
>>       snd_jack_new(chip->card, "Headphone",
>> -                  SND_JACK_HEADPHONE, &data->hp_jack);
>> +                  SND_JACK_HEADPHONE, 0, &data->hp_jack);
>>       xonar_ds_handle_hp_jack(chip);
>
> ...this really ought to be done as part of the commit that adds the
> parameter since it breaks the build until this patch is applied.

But that's why is a patch series. But as you say, are you suggesting
me to propose this changes in one patch only?

Felipe Tonello
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/