Re: [PATCH 18/21] x86, numa: Synchronize nid info in memblock.reservewith numa_meminfo.

[Tang Chen]

On 07/25/2013 11:05 PM, Tejun Heo wrote:
> Hello, Tang.
>
> On Thu, Jul 25, 2013 at 12:09:29PM +0800, Tang Chen wrote:
> > And as in [patch 14/21], when reserving hotpluggable memory, we use
> > pxm. So my
>
> Which is kinda nasty.

Yes, will remove it.

> > idea was to do a nid sync in numa_init(). After this, memblock will
> > set nid when
> > it allocates memory.
>
> Sure, that's the only place we can set the numa node IDs but my point
> is that you don't need to add another interface.  Jet let
> memblock_set_node() handle both memblock.memory and .reserved ranges.
> That way, you can make memblock simpler to use and less error-prone.

Yes, I missed the isolation phase in memblock_set_node().
So followed.

> > If we want to let memblock_set_node() and alloc functions set nid on
> > the reserved
> > regions, we should setup nid<->  pxm mapping when we parst SRAT for
> > the first time.
>
> I don't follow why it has to be different.  Why do you need to do
> anything differently?  What am I missing here?

No, it was me who missed the isolation phase in memblock_set_node().

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/