Re: [patch] Revert "page-writeback.c: subtract min_free_kbytes fromdirtyable memory"

From: Minchan Kim
Date: Thu Jul 25 2013 - 19:30:24 EST


On Thu, Jul 25, 2013 at 06:58:54PM -0400, Johannes Weiner wrote:
> This reverts commit 75f7ad8e043d9383337d917584297f7737154bbf. It was
> the result of a problem observed with a 3.2 kernel and merged in 3.9,
> while the issue had been resolved upstream in 3.3 (ab8fabd mm: exclude
> reserved pages from dirtyable memory).
>
> The "reserved pages" are a superset of min_free_kbytes, thus this
> change is redundant and confusing. Revert it.
>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Absolutely true and I pointed it out at that time but ignored and merged. :(
http://lists.debian.org/debian-kernel/2013/01/msg00538.html
Even, not Cced so I couldn't notice it until you send out this patch.

Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/