Re: [PATCH 0/4] iommu: Add event tracing feature to iommu

[Shuah Khan]

On 07/25/2013 07:27 AM, Steven Rostedt wrote:
> On Thu, 2013-07-25 at 07:15 -0600, Shuah Khan wrote:
>
>> Shuah Khan (4):
>>    iommu: Add event tracing feature to iommu - Add iommu trace events
>>    iommu: Add event tracing feature to iommu - export trace events
>>    iommu: Add event tracing feature to iommu - amd_iommu driver trace
>>      events
>>    iommu: Add event tracing feature to iommu - iommu driver trace events
>>
>>   drivers/iommu/Makefile       |    1 +
>>   drivers/iommu/amd_iommu.c    |   19 +++++
>>   drivers/iommu/iommu-traces.c |   27 +++++++
>>   drivers/iommu/iommu.c        |   17 ++++-
>>   include/trace/events/iommu.h |  174 ++++++++++++++++++++++++++++++++++++++++++
>>   5 files changed, 237 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/iommu/iommu-traces.c
>>   create mode 100644 include/trace/events/iommu.h
>
> I don't know what the maintainer thinks, but usually new tracepoints
> like this are done as one patch. Not four.
>
> -- Steve
>

If one single patch is preferred, I can easily generate one. Does the 
code look good otherwise?

-- Shuah

Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research 
America (Silicon Valley) shuah.kh@xxxxxxxxxxx | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/