Re: [PATCH 7/7] usb: phy: msm: Lindent the code

From: Felipe Balbi
Date: Thu Jul 25 2013 - 10:22:20 EST


Hi,

On Thu, Jul 25, 2013 at 04:40:51PM +0300, Ivan T. Ivanov wrote:
> > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> > > index 6d05085..111f454 100644
> > > --- a/drivers/usb/phy/phy-msm-usb.c
> > > +++ b/drivers/usb/phy/phy-msm-usb.c
> > > @@ -64,8 +64,8 @@ static int msm_hsusb_init_vddcx(struct msm_otg *motg, int init)
> > >
> > > if (init) {
> > > ret = regulator_set_voltage(motg->vddcx,
> > > - USB_PHY_VDD_DIG_VOL_MIN,
> > > - USB_PHY_VDD_DIG_VOL_MAX);
> > > + USB_PHY_VDD_DIG_VOL_MIN,
> > > + USB_PHY_VDD_DIG_VOL_MAX);
> >
> > like here, what's the point ?
>
> It makes indentation the same like the majority of the code.
> I could drop this patch if you like.

yeah, I don't think it's worth to have this patch. Just looked at the
driver and, at least to my eyes, it didn't look all that bad. Matter of
taste though

--
balbi

Attachment: signature.asc
Description: Digital signature