Re: [PATCH net-next] tuntap: hardware vlan tx support

[Stephen Hemminger]

On Wed, 24 Jul 2013 13:55:14 +0800
Jason Wang <jasowang@xxxxxxxxxx> wrote:

> On 07/23/2013 11:53 PM, Stephen Hemminger wrote:
> > On Tue, 23 Jul 2013 15:15:48 +0800
> > Jason Wang <jasowang@xxxxxxxxxx> wrote:
> >
> >> +		struct {
> >> +			__be16 h_vlan_proto;
> >> +			__be16 h_vlan_TCI;
> >> +		} veth;
> > Don't you want to use struct vlan_hdr here? 
> 
> There's no need to care encapsulated proto here. In fact, we just
> emulate the hardware inserting of 802.1Q header. So only skb->vlan_tci
> and skb->vlan_proto needs to be cared.
> > Your definition puts the two fields out of order?
> 
> It's order is same as struct vlan_ethhdr. Did you see any issue?

I was looking at if_vlan.h struct vlan_hdr. The veth structure
is a slice between ether and vlan header.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/