Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.

[Tejun Heo]

On Tue, Jul 23, 2013 at 12:15:58PM -0700, Joe Perches wrote:
> > The following would be more conventional.
> > 
> >   "...10Lx]%s\n", ..., hotpluggable ? " Hot Pluggable" : ""
> > 
> > Also, isn't "Hot Pluggable" a bit too verbose?  "hotplug" should be
> > fine, I think.
> 
> It's also a tiny nit better to use:
> 
> 	pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s\n",
> 		node, pxm,
> 		(unsigned long long) start, (unsigned long long) end - 1,
> 		hotpluggable ? " Hot Pluggable" : "");
> 
> (or " hotplug")
> 
> so there's no space before newline.

Which was my first point which apparently wasn't clear enough. :)

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/