Re: [PATCH] Staging: bcm: Qos: Fix some coding style issues

From: Lilis Iskandar
Date: Tue Jul 23 2013 - 14:25:44 EST


On Tue, 2013-07-23 at 09:42 -0700, Joe Perches wrote:
> On Tue, 2013-07-23 at 19:51 +0800, Lilis Iskandar wrote:
> > Fixed spacing/tabs issues that were found using checkpatch.
>
> Hi Lilis.
>
> It'd be better to change the email subject to
> "[PATCH v2] etc..." to show that's it's a new
> version of the patch.
>
> It's also useful to add a note or two like
> "git diff -w shows no differences" and
> "no differences in objects" to make review
> and acceptance a bit easier.
>
> Good luck with continued cleanups of bcm.
> There's a lot to clean in those files.

Thanks for the advice! I'll keep that in mind for the following patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/