Re: [alsa-devel] [PATCH] ARM: kirkwood: enable S/PDIF

From: Mark Brown
Date: Tue Jul 23 2013 - 09:26:36 EST


On Tue, Jul 23, 2013 at 03:12:56PM +0200, Sebastian Hesselbarth wrote:

> the mask that is changed in the patch is what will be written
> into i2s controller's registers. So, if there is no S/PDIF in that
> specific controller that bit can possibly have a different meaning.
> Also, enabling both I2S playback and SPDIF playback can cause the
> controller to behave differently.

Oh, so it will - I glanced through it and misread, sorry. If it just
makes the enabling of S/PDIF mode conditional on DAI format that'd cover
it.

> I share Russell's concern about it and would rather like to use
> multiple codecs per DAI (DPCM) for that. I see Daniel Mack picked
> that up again, maybe he submits something soon.

Well, that'd be ideal and is going to be needed for any hardware which
has both wired up in parallel but a simpler either/or thing doesn't seem
like a problem.

Attachment: signature.asc
Description: Digital signature