Re: [PATCH] ARM: kirkwood: enable S/PDIF

From: Russell King - ARM Linux
Date: Tue Jul 23 2013 - 09:21:37 EST


On Tue, Jul 23, 2013 at 02:06:22PM +0100, Mark Brown wrote:
> On Tue, Jul 23, 2013 at 09:43:47AM +0100, Russell King - ARM Linux wrote:
> > On Tue, Jul 23, 2013 at 10:23:20AM +0200, Jean-Francois Moine wrote:
> > > This patch enables S/PDIF.
>
> > > Signed-off-by: Jean-Francois Moine <moinejf@xxxxxxx>
>
> > I'm not submitting my patch to do this because:
>
> > (a) we don't know what effect this has on other hardware.
>
> This patch will do absolutely nothing unless it's used in a machine
> driver which connects a S/PDIF CODEC to it. I see no reason not to
> apply it, someone with hardware with more complex needs can always build
> on it later.

So... what if setting this bit causes the SoC to start wiggling a pin
with the SPDIF signal which has been used for a different purpose?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/