Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2

From: Vince Weaver
Date: Tue Jul 23 2013 - 01:39:45 EST


On Mon, 22 Jul 2013, Andi Kleen wrote:

> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> Add a precise qualifier, like cpu/event=0x3c,precise=1/

So you're adding this to "events/" but not to "format/"?

This breaks the ABI, which specifies that the only fields
that can appear in a sysfs events specifier must exist under
the format directory.

This was what I worried about when I said people are going to start
leaking perf tool specific events into the kernel sysfs tree.

This will break various existing programs.

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/