Re: [PATCH V2] relay: fix timer madness

[Dan Carpenter]

On Wed, Jul 10, 2013 at 10:18:54AM +0800, zhangwei(Jovi) wrote:
> @@ -339,6 +339,10 @@ static void wakeup_readers(unsigned long data)
>  {
>  	struct rchan_buf *buf = (struct rchan_buf *)data;
>  	wake_up_interruptible(&buf->read_wait);
> +	/*
> +	 * Stupid polling for now:
> +	 */
> +	mod_timer(&buf->timer, HZ / 10);

mod_timer() takes an offset so probably "jiffies + HZ / 10" was
intended here and also below.  Certainly passing "HZ / 10" doesn't
make any kind of sense.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/