Re: [PATCH RFT] irqchip: sun4i: Remove wrong irq_ack callback implementation

[Geert Uytterhoeven]

On Thu, Jul 11, 2013 at 6:13 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Jul 06, 2013 at 10:35:29PM +0800, Axel Lin wrote:
>> According to the datasheet[1], the Interrupt IRQ Pending Registers are
>> read-only. The implementation of sun4i_irq_ack() looks wrong because it writes
>> to these read-only registers.
>
> Right, but the datasheet also says that these registers are "clear"
> register, which might indicate that it's actually R/W.

I guess it means that the flags are cleared automatically on read?
That's not so uncommon for interrupt pending registers.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/