Re: [PATCH v2] kconfig: switch to "long long" for sanity

From: Kees Cook
Date: Thu Jul 18 2013 - 18:01:13 EST


On Thu, Jul 18, 2013 at 1:47 PM, Yann E. MORIN <yann.morin.1998@xxxxxxx> wrote:
> Kees, Geert, All,
>
> On 2013-07-18 22:00 +0200, Geert Uytterhoeven spake thusly:
>> On Thu, Jul 18, 2013 at 8:32 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> > Instead of using "long" for kconfig "hex" and "range" values, which may
>> > change in size depending on the host architecture, use "long long". This
>> > will allow values greater than INT_MAX on 32-bit hosts when cross
>> > compiling.
>> >
>> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>
>> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> Ok, thanks, I'll take in my tree.
>
> Is it material for -rc-fixes, or can it wait in -for-next?
>
> My gut feelings is that it does not fix an existing breakage, but only a
> potential problem in the future, so it would be a candidate for
> -for-next. Agreed?

Correct. I'm not aware of anything in the tree that currently uses
>INT_MAX values in kconfig.

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/