Re: [PATCH 4/30] ACPI / hotplug / PCI: Hotplug context objects for bridges and functions

From: Rafael J. Wysocki
Date: Thu Jul 18 2013 - 15:56:48 EST


On Thursday, July 18, 2013 09:04:11 PM Rafael J. Wysocki wrote:
> On Wednesday, July 17, 2013 07:00:33 PM Yinghai Lu wrote:
> > On Wed, Jul 17, 2013 at 4:17 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > >
> > > When either a new hotplug bridge or a new hotplug function is added
> > > by the ACPI-based PCI hotplug (ACPIPHP) code, attach a context object
> > > to its ACPI handle to store hotplug-related information in it. To
> > > start with, put the handle's bridge and function pointers into that
> > > object. Count references to the context objects and drop them when
> > > they are not needed any more.
> > >
> > > First of all, this makes it possible to find out if the given bridge
> > > has been registered as a function already in a much more
> > > straightforward way and acpiphp_bridge_handle_to_function() can be
> > > dropped (Yay!).
> > >
> > > This also will allow some more simplifications to be made going
> > > forward.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > > ---
> > > drivers/pci/hotplug/acpiphp.h | 10 ++
> > > drivers/pci/hotplug/acpiphp_glue.c | 179 ++++++++++++++++++++++++++++---------
> > > 2 files changed, 146 insertions(+), 43 deletions(-)
> >
> > no, more lines are added.
>
> Well, that's what 'quilt refresh --diffstat' tells me, quite consistently.
>
> Have you actually counted them?

Now I have done that (using "grep '^+' | wc -l") and that indeed turns out ot
the right number.

What gives?

Rafael


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/