Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

[Joe Perches]

On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote:
> Use the dev_* message logging API instead of raw printk.
[]
> diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
[]
> @@ -595,7 +595,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
>  	 * matching with device name
>  	 */
>  	if (NULL == vpbe_dev || NULL == dev) {
> -		printk(KERN_ERR "Null device pointers.\n");
> +		dev_err(dev, "Null device pointers.\n");

And if dev actually is NULL?

btw: canonical forms for this test are
	(if vpbe_dev == NULL || dev == NULL)
or
	if (!bpbe_dev || !dev)

I stopped reading here.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/