Re: [patch] Squashfs: sanity check information from disk

From: Dan Carpenter
Date: Wed Jul 17 2013 - 08:20:34 EST


On Wed, Jul 17, 2013 at 05:20:31AM +0100, Phillip Lougher wrote:
> On 15 July 2013 17:17, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > We read the size of the name from the disk, but a larger name than
> > expected would cause memory corruption.
>
> Thanks for the patch, it's queued for the next merge window. There's
> one mistake with the patch, but I can fix it when it's applied, or you
> can send a revised patch (see later).

I wouldn't call it a "mistake", it's just a difference in prefered
styles. The two statements:

if (size >= SQUASHFS_NAME_LEN + 1) {
and
if (size > SQUASHFS_NAME_LEN) {

These statements are equivalent. But I can change it, no worries.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/