Re: [PATCH RESEND 1/2] fs/anon_inode: Introduce a new lib function anon_inode_getfile_private()

From: Benjamin LaHaise
Date: Tue Jul 16 2013 - 09:16:20 EST


On Tue, Jul 16, 2013 at 05:56:12PM +0800, Gu Zheng wrote:
>
> Introduce a new lib function anon_inode_getfile_private(), it creates a new file
> instance by hooking it up to an anonymous inode, and a dentry that describe the
> "class" of the file, similar to anon_inode_getfile(), but each file holds a
> single inode. Furthermore, anyone who wants to create a private anon file will
> benefit from this change.
>
> Signed-off-by: Gu Zheng <guz.fnst@xxxxxxxxxxxxxx>
> Signed-off-by: Benjamin LaHaise <bcrl@xxxxxxxxx>

Please don't add my Signed-off-by when I have never even seen or reviewed
a patch -- that is completely unacceptable. Second, I don't think this
patch is suitable for 3.11, as it has not seen much testing outside of one
test program I had written. It's a long standing bug, so it isn't urgent
to get the fix into the tree. That said, it did pass a few tests I ran
last night, so it is probably suitable for the -next tree.

As for patch 1, it looks okay to me, but will need Al Viro's signoff.

-ben
--
"Thought is the essence of where you are now."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/